Improve failure message for comparison expectations #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the digits calculation from waldo, displaying the actual calculation, comparison, and renaming "more" to "greater" Fixes #2006
R/expect-comparison.R
Outdated
| ">=" = "not greater than" | ||
| )[[operator]] | ||
|
|
||
| negated_op <- switch(operator, "<" = ">", "<=" = ">=", ">" = "<", ">=" = "<=") |
Contributor
There was a problem hiding this comment.
Aren't these wrong? e.g. I think we'll get
expect_snapshot_failure(expect_gt(x, 1.0 * x))
`x` is not strictly greater than 1.0 * x.
0.0000100 - 0.0000110 = 0 < 0
The negated open interval is a closed interval, and vice versa.
(even if I'm reading it wrong we'll still want a test of the edge case)
Member
Author
There was a problem hiding this comment.
Also that revealed a bug when the number of digits in the difference is much smaller than the values.
Contributor
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
Great, output LGTM! It might be helpful to add another example where the values are totally different just to get a glimpse of what that will look like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the digits calculation from waldo, displaying the actual calculation, comparison, and renaming "more" to "greater"
Fixes #2006
@MichaelChirico could you please take a look? This doesn't need to be perfect, but is hopefully better than the current display.